Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-135321] Adding the content root #13

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[MWPW-135321] Adding the content root #13

merged 1 commit into from
Aug 30, 2023

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds the contentRoot to config

Note: To verify you need to look in the network tab and make sure that the requests for the gnav and footer have /blog in the request URI.

Resolves: MWPW-135321

Test URLs:

@meganthecoder
Copy link
Contributor

I see a 404 for https://content-root--bacom-blog--adobecom.hlx.page/fragments/gnav/explore-menu.plain.html. Is that because the page isn't previewed or because it should have /blog in the path? It seems like we could run into collisions with business.adobe.com fragments if we don't prefix the blog fragments with /blog

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Page Scores Audits Google
/drafts/bulk-update/MWPW-135074-CSS-Styles/10-best-practices-for-using-links-in-
emails?martech=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JasonHowellSlavin
Copy link
Contributor Author

I see a 404 for https://content-root--bacom-blog--adobecom.hlx.page/fragments/gnav/explore-menu.plain.html. Is that because the page isn't previewed or because it should have /blog in the path? It seems like we could run into collisions with business.adobe.com fragments if we don't prefix the blog fragments with /blog

I saw that, was thinking authoring might want to author under blog but now that I am thinking about it they would have to / should author those fragments under each locale under blog or else there will be collisions as you mention. Something I will add to that wiki.

I previewed under bacom-blog to get rid of the 404 for now.

@JasonHowellSlavin JasonHowellSlavin merged commit 7f219cb into main Aug 30, 2023
2 of 3 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the content-root branch August 30, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brandon32 Brandon32 Brandon32 approved these changes

@meganthecoder meganthecoder meganthecoder approved these changes

@rgclayton rgclayton Awaiting requested review from rgclayton

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonHowellSlavin @meganthecoder @Brandon32